Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show phone number as target for email notifs #3530

Merged
merged 2 commits into from
Mar 28, 2017
Merged

Don't show phone number as target for email notifs #3530

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83b7f94
Don't show phone number as target for email notifs
dbkr Mar 28, 2017
c72a49d
More equalses
dbkr Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/components/views/settings/Notifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,20 +719,17 @@ module.exports = React.createClass({
);
}

var emailNotificationsRow;
if (this.props.threepids.filter(function(tp) {
if (tp.medium == "email") {
return true;
}
}).length == 0) {
const emailThreepids = this.props.threepids.filter((tp) => tp.medium == "email");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: ===

let emailNotificationsRow;
if (emailThreepids.length == 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and again

emailNotificationsRow = <div>
Add an email address above to configure email notifications
</div>;
} else {
// This only supports the first email address in your profile for now
emailNotificationsRow = this.emailNotificationsRow(
this.props.threepids[0].address,
"Enable email notifications ("+this.props.threepids[0].address+")"
emailThreepids[0].address,
"Enable email notifications ("+emailThreepids[0].address+")"
);
}

Expand Down