Refactor login page #355
Merged
Refactor login page #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'PasswordLogin' UI component - Add 'LoginPage' wire component which, along with Signup from react SDK, replaces the 'Login' page. - Move UI code (state/props) from ServerConfig which was lobotomoised in the React SDK. Unfinished.
…hough in React like this.
| @@ -0,0 +1,199 @@ | |||
| /* | |||
There was a problem hiding this comment.
The components this pulls in are from the new src/components/ directory, split by functionality, but this new style non-split component is still part of the views hierarchy, mixed in with all the old, split components? 'views' were supposed to be the UI part of a component: this is a complete component, not a view?
There was a problem hiding this comment.
The intention is for this to be a complete component. Based on your comments, would you prefer if it were in the components directory to avoid confusion?
|
See comments in matrix-org/matrix-react-sdk#31 |
|
/me wonders why this has been assigned to me |
|
LGTM'd by Dave irl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the sister PR to matrix-org/matrix-react-sdk#31.
This PR:
ServerConfiga normal component rather than just the view.CasLoginand uses the entire component from React SDK.templates/Loginwithpages/Loginwhich wires together UI components with theSignuplogic.