Use multipart-form encoding for rageshake uploads #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, please don't merge this until I land the other end! |
|
lgtm modulo TextEncoder test fail |
dbkr
approved these changes
Apr 18, 2017
This is a more sensible encoding for uploading logfiles, and will allow us to compress the logfiles in future. browser-request doesn't give us enough flexibility to do this properly, so we use XMLHttpRequest directly.
richvdh
force-pushed
the
rav/multipart_rageshake
branch
from
faa8068 to
9c186da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more sensible encoding for uploading logfiles, and will allow us to compress the logfiles in future.
browser-request doesn't give us enough flexibility to do this properly, so we use XMLHttpRequest directly.
See https://github.com/matrix-org/rageshake/blob/caf57b60cbfda2652fa577397aaebb4df04449f7/README.md#post-apisubmit for the API details.
(builds on top of #3645. The actual changes are in 0561c8c.)