Read receipts #379
Merged
Read receipts #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot easier to animate. Also mess around with the MemberAvatar a bit so it's easier to style.
…more start states and then settle on the final place.
| @@ -529,7 +542,7 @@ module.exports = { | |||
| } | |||
|
|
|||
| ret.unshift( | |||
| <li key={mxEv.getId()}><EventTile mxEvent={mxEv} continuation={continuation} last={last}/></li> | |||
| <li key={mxEv.getId()} ref={this._collectEventNode.bind(this, mxEv.getId())}><EventTile mxEvent={mxEv} continuation={continuation} last={last}/></li> | |||
There was a problem hiding this comment.
This looks like the same stuff we're doing in React SDK?
There was a problem hiding this comment.
Yep, trying to merge the same changes over to the duplicated controller in react sdk :(
|
LGTM though I can't really say much about the velocity stuff. The PR is too large for my poor brain to grok it fully. From what I can grok, it looks good though :D |
…y overalpping) and exclude ourselves.
…companying text (as with read receipts) they can be somewhat unhelpful. May as well have them all the time I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.