Refactor registration #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook it up to MatrixChat instead of the existing logic (this breaks reg). WIP.
This is complex enough that the Registration component shouldn't have to care about it, so it should probably be split into a pure UI component.
…HTTP hit if we've been given good QPs
This has to be done rather than in MatrixChat because the render() calls will create new instances otherwise. Pass in all the strings the logic class requires to the Registration wire component. This isn't the "best" solution because unloading/reloading the Registration component will lose registration state which should be persisted. Ideally we'd DI from the top to ensure this can't happen (as opposed to relying on module globals...)
| </div> | ||
| ); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This component look simple / generic enough it could potentially go into react-sdk in the long term?
There was a problem hiding this comment.
Absolutely, I should've seen that. Will re-jig now else I'll never get around to it.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the sister PR to matrix-org/matrix-react-sdk#34
This PR factors out a lot of UI components from the
Registercomponent. The new components are:CaptchaForm- Renders thedivwhich Recaptcha needs. Does thecomponentDidUpdatescript voodoo to make it actually work.RegistrationForm- Contains the elements for the email/user/password. Does basic validation like checking passwords match/exist/length and calls theonErrorprop accordingly.It adds a new wire component
Registrationwhich glues everything together. Specifically it:Signup.Register.CaptchaForm).There's a few things I'd like to do to improve this further, but I'm conscious of keeping PRs manageable so have littered a few
TODOs.Manually tested: