Use chrome headless instead of phantomjs #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
reviewed
Jul 5, 2017
There was a problem hiding this comment.
Thank you!
Only thing I would say is that npm run test now depends on having a chrome available, which will not be the case in general. The only other option is using phantomjs by default and overriding it to chrome headless on travis. I'm inclined to think just depending on chrome is the lesser evil. Maybe we should put a note in the readme?
|
Yeah, I'm not keen on keeping support for PhantomJS around. I'll add something to the readme about running the tests. |
dbkr
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhantomJS is creaky, and it turns out to be surprisingly easy just to use Chrome in headless mode.