-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch riot-web to bluebird #4565
Merged
Merged
Commits on Jul 12, 2017
-
replace imports of
q
with bluebirdupdate `package.json` ``` find src test -name '*.js' | xargs perl -i -pe 'if (/require\(.[qQ].\)/) { $_ = "import Promise from '\''bluebird'\'';\n"; }' find src test -name '*.js' | xargs perl -i -pe 'if (/import [qQ] /) { $_ = "import Promise from '\''bluebird'\'';\n"; }' ```
Configuration menu - View commit details
-
Copy full SHA for 10decf9 - Browse repository at this point
Copy the full SHA 10decf9View commit details -
``` find src test -name '*.js' | xargs perl -i -pe 's/\b[qQ]\(/Promise.resolve(/' ```
Configuration menu - View commit details
-
Copy full SHA for b29b4a9 - Browse repository at this point
Copy the full SHA b29b4a9View commit details -
replace q method calls with bluebird ones
``` find src test -name '*.js' | xargs perl -i -pe 's/q\.(all|defer|reject|delay|try|isFulfilled)\(/Promise.$1(/' ```
Configuration menu - View commit details
-
Copy full SHA for d5b550f - Browse repository at this point
Copy the full SHA d5b550fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c5b5ca - Browse repository at this point
Copy the full SHA 4c5b5caView commit details -
Bluebird doesn't have an `allSettled` method, so instead catch the exceptions and use `all`.
Configuration menu - View commit details
-
Copy full SHA for 1d2d086 - Browse repository at this point
Copy the full SHA 1d2d086View commit details -
turns out that you could call defer.resolve on q defers as an unbound function, whereas that doesn't work with bluebird promises.
Configuration menu - View commit details
-
Copy full SHA for 69eb1a4 - Browse repository at this point
Copy the full SHA 69eb1a4View commit details
Commits on Jul 13, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7238c4d - Browse repository at this point
Copy the full SHA 7238c4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76181f4 - Browse repository at this point
Copy the full SHA 76181f4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.