Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out EditableItemList component from AliasSettings #5161

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Factor out EditableItemList component from AliasSettings #5161

merged 1 commit into from
Oct 4, 2017

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Oct 4, 2017 •
edited
Loading

@lukebarnard1 lukebarnard1 mentioned this pull request Oct 4, 2017
Merged
@lukebarnard1
Copy link
Contributor Author

lukebarnard1 commented Oct 4, 2017 •
edited
Loading

Very strange that one of the builds failed with an undefined function error. This was the same error that went away when we merged develop into #5110 (comment). Feels unrelated so I'll ignore it for now.

@lukebarnard1 lukebarnard1 merged commit 56c366e into develop Oct 4, 2017
@t3chguy t3chguy deleted the luke/refactor-editable-list-from-alias-settings branch May 12, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @dbkr