Add more props to RoomSubList #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved room clicking
…etween props.collapsed and state.hidden
startAsHidden: Previously we never started in the hidden state and all was well. But with archived rooms you DO want to start hidden as you haven't fetched the room list yet. Without this, you need to click twice (close/open) before the archived room list will load. showSpinner: If true, will show a spinner iff there are 0 elements being displayed. Used when fetching the archived room list in RoomList.
This was referenced Dec 18, 2015
|
lgtm other than comment on matrix-org/matrix-react-sdk#62 |
|
lgtm if it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for #348
alwaysShowHeaderhas been added to force the title to be shown even if there are 0 elements. Required so people can actually click the archived header.showSpinnerhas been added to make a spinner spin if there are 0 elements. Required so people know a request is ongoing whilst getting archived rooms.onHeaderClickhas been added so we can call the JS SDK when the archived room header is clicked.startAsHiddenhas been added to allow the initial collapsed/expanded state to be modified. Required because the archived section should be collapsed by default as we don't yet have the rooms until you try to expand it.Also added a
TODOquestioning the naming ofprops.collapsed- it's terribly confusing because I think of collapsed as "no rooms are showing but you can expand them" but that is actually represented in the code asstate.hidden = true.See also: