-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move everything not explicitly riot (or status) branded into matrix-react-sdk #6500
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3ecbfae
move everything not explicitly riot (or status) branded into matrix-r…
ara4n e899fec
move themes to res to match sdk
ara4n 8757c8c
move notif UTs to sdk
ara4n 41d6995
fix braindead typo
ara4n f569fdd
make VectorHomePage override HomePage
ara4n 534155f
point to new CSS locations
ara4n be34c84
fix theme paths
ara4n 3d20a64
export enum via method for convenience from matrix-react-sdk
ara4n aefb782
move conference handler to matrix-react-sdk
ara4n d693125
move rageshake to sdk
ara4n a46b718
copy resources from their new locations
ara4n b8d4866
run gen-i18n to refresh translations now most are moved to react-sdk
ara4n ce36dec
run prune-i18n to bring translations inline now most are moved to rea…
ara4n 0243ec0
switch karma image loc
ara4n 7c1eafd
merge develop
ara4n 8684fae
kill theming 404s when UTing
ara4n 5c34115
fix theming during tests correctly
ara4n c8b26a1
fix tests
ara4n 7ee5343
convert VectorHomePage into ES6 and have it nicely override HomePage
ara4n df3fb83
move deps to sdk for stuff now in the sdk
ara4n e046a72
flesh out status todo comment
ara4n 104a415
PR feedback; fix staticness and add ;s
ara4n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Any UTs for vector-web layer components or functionality should go here. | ||
This used to contain the UTs for notifications before they got moved to react-sdk. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message is misleading here. Should there be changes to the tests as part of this commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, this was a terrible commit message. the thing that was breaking the tests is that the
unit-tests
dir had winked out of existence. creating this README file recreated the directory and fixed the tests O:-)