Iterate on notification count

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Use numUnreadMentions and numUnreadMessages from the SDK in replacement for notificationCount.
The rules for the badges are in this issue: #2079.

I did not repro the issue described here: #2130 (review) 🎉 . But maybe @jmartinesp can double check 🙏 .

Motivation and context

Closes (again) #2079
Closes #1450

Screenshots / GIFs

Tests

• Observe the room list badge and check that behavior is correct when new messages with or without mention are received, with different notification room settings.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/EKm9F1

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (bee56c8) 70.05% compared to head (958e97f) 70.11%.
Report is 3 commits behind head on develop.

Files	Patch %	Lines
...eatures/roomlist/impl/components/RoomSummaryRow.kt	88.37%	1 Missing and 4 partials ⚠️
...eatures/roomlist/impl/model/RoomListRoomSummary.kt	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2265      +/-   ##
===========================================
+ Coverage    70.05%   70.11%   +0.05%     
===========================================
  Files         1335     1335              
  Lines        32684    32758      +74     
  Branches      6793     6807      +14     
===========================================
+ Hits         22896    22967      +71     
- Misses        6512     6513       +1     
- Partials      3276     3278       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

One small remark otherwise LGTM

[ganfra]

Makes it a computed val instead

[bmarty]

958e97f

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud