Avoid restoring several MatrixClient

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Use MatrixClientProvider instead of restoring a MatrixClient from the AuthenticationService.

Motivation and context

Attempt to fix #3028

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qkmema

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.86%. Comparing base (7b5e7c4) to head (874bf5b).
Report is 10 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3050      +/-   ##
===========================================
- Coverage    75.86%   75.86%   -0.01%     
===========================================
  Files         1628     1628              
  Lines        38378    38378              
  Branches      7410     7410              
===========================================
- Hits         29117    29115       -2     
- Misses        5388     5389       +1     
- Partials      3873     3874       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

Oh, nice! Hopefully this might get rid of the duplicate refreshes.

Just a note: I was also trying to investigate this and I noticed MatrixClientProvider.restoreWithSavedState is the only method that doesn't use the Mutex to restore the session. While it's quite unlikely there may be a moment when the client already exists but sessionIdsToMatrixClient is not updated if I'm not mistaken. Maybe it's worth it to add a lock there too.

[bmarty]

Oh, nice! Hopefully this might get rid of the duplicate refreshes.

Just a note: I was also trying to investigate this and I noticed MatrixClientProvider.restoreWithSavedState is the only method that doesn't use the Mutex to restore the session. While it's quite unlikely there may be a moment when the client already exists but sessionIdsToMatrixClient is not updated if I'm not mistaken. Maybe it's worth it to add a lock there too.

Yes, good point. I have done it a bit differently, and I think it's fine: 874bf5b is it OK for you?

[jmartinesp]

Yes, good point. I have done it a bit differently, and I think it's fine: 874bf5b is it OK for you?

Yes, that's actually a lot simpler, thanks!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud