Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improve offline indicator designs #341

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

jmartinesp
Copy link
Member

Changes the font weight for the offline indicator text from regular to medium, as asked by @callumu here.

Also does some cleanup of unneeded suppressions of warnings in the network-indicator module and other build files.

@jmartinesp jmartinesp requested review from a team and bmarty and removed request for a team April 19, 2023 09:31
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gUEgAE

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup. I guess the screenshot tests need to be recorded again.

@jmartinesp jmartinesp force-pushed the fix/jme/improve-offline-indicator-designs branch from a225e2a to d9f91ce Compare April 19, 2023 13:43
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 64.49% and project coverage change: +0.48 🎉

Comparison is base (1eb07e0) 46.11% compared to head (d9f91ce) 46.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #341      +/-   ##
===========================================
+ Coverage    46.11%   46.59%   +0.48%     
===========================================
  Files          610      619       +9     
  Lines        13610    13932     +322     
  Branches      2856     2919      +63     
===========================================
+ Hits          6276     6492     +216     
- Misses        6159     6228      +69     
- Partials      1175     1212      +37     
Impacted Files Coverage Δ
...res/invitelist/impl/DefaultInviteListEntryPoint.kt 0.00% <0.00%> (ø)
.../android/libraries/matrix/impl/RustMatrixClient.kt 0.00% <0.00%> (ø)
...ries/matrix/impl/room/RoomSummaryDetailsFactory.kt 0.00% <0.00%> (ø)
...android/features/invitelist/impl/InviteListView.kt 46.15% <46.15%> (ø)
...es/designsystem/theme/components/OutlinedButton.kt 47.05% <47.05%> (ø)
...ent/android/features/roomlist/impl/RoomListView.kt 63.26% <70.00%> (+0.22%) ⬆️
...res/invitelist/impl/components/InviteSummaryRow.kt 80.00% <80.00%> (ø)
...id/features/invitelist/impl/InviteListPresenter.kt 81.57% <81.57%> (ø)
...ndroid/features/invitelist/impl/InviteListState.kt 100.00% <100.00%> (ø)
...eatures/invitelist/impl/InviteListStateProvider.kt 100.00% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmartinesp jmartinesp merged commit 747a2e7 into develop Apr 19, 2023
@jmartinesp jmartinesp deleted the fix/jme/improve-offline-indicator-designs branch April 19, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants