Address PR comments

element-hq · Sep 27, 2024 · 3aa3db6 · 3aa3db6
1 parent 358146e
commit 3aa3db6
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/ElementX/Sources/Other/SwiftUI/Views/LoadableAvatarImage.swift b/ElementX/Sources/Other/SwiftUI/Views/LoadableAvatarImage.swift
@@ -37,22 +37,23 @@ struct LoadableAvatarImage: View {
             Button {
                 onTap(url)
             } label: {
-                avatar
-                    .frame(width: frameSize, height: frameSize)
-                    .background(Color.compound.bgCanvasDefault)
-                    .clipShape(Circle())
+                clippedAvatar
             }
             .buttonStyle(.borderless) // Add a button style to stop the whole row being tappable.
         } else {
-            avatar
-                .frame(width: frameSize, height: frameSize)
-                .background(Color.compound.bgCanvasDefault)
-                .clipShape(Circle())
+            clippedAvatar
         }
     }
 
+    private var clippedAvatar: some View {
+        avatar
+            .frame(width: frameSize, height: frameSize)
+            .background(Color.compound.bgCanvasDefault)
+            .clipShape(Circle())
+    }
+
     @ViewBuilder
-    var avatar: some View {
+    private var avatar: some View {
         if let url {
             LoadableImage(url: url,
                           mediaType: .avatar,