Fixes #2325 - Prevent the same WebView from being reused for multiple…

… Element Call links
element-hq · Jan 16, 2024 · 8ab3d19 · 8ab3d19
1 parent b21194b
commit 8ab3d19
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/ElementX/Sources/Mocks/Generated/GeneratedMocks.swift b/ElementX/Sources/Mocks/Generated/GeneratedMocks.swift
@@ -1,4 +1,4 @@
-// Generated using Sourcery 2.1.3 — https://github.com/krzysztofzablocki/Sourcery
+// Generated using Sourcery 2.1.2 — https://github.com/krzysztofzablocki/Sourcery
 // DO NOT EDIT
 
 // swiftlint:disable all

diff --git a/ElementX/Sources/Screens/CallScreen/View/CallScreen.swift b/ElementX/Sources/Screens/CallScreen/View/CallScreen.swift
@@ -23,6 +23,7 @@ struct CallScreen: View {
 
     var body: some View {
         WebView(url: context.viewState.url, viewModelContext: context)
+            .id(UUID())
             .ignoresSafeArea(edges: .bottom)
             .presentationDragIndicator(.visible)
             .environment(\.colorScheme, .dark)

diff --git a/ElementX/Sources/Screens/Other/GenericCallLinkCoordinator.swift b/ElementX/Sources/Screens/Other/GenericCallLinkCoordinator.swift
@@ -36,6 +36,7 @@ class GenericCallLinkCoordinator: CoordinatorProtocol {
     func toPresentable() -> AnyView {
         AnyView(
             WebView(url: parameters.url)
+                .id(UUID())
                 .ignoresSafeArea(edges: .bottom)
                 .presentationDragIndicator(.visible)
         )

diff --git a/changelog.d/2325.bugfix b/changelog.d/2325.bugfix
@@ -0,0 +1 @@
+Prevent the same WebView from being reused for multiple Element Call links
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Prevent the same WebView from being reused for multiple Element Call links