Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling Face ID no longer presents the PIN screen. #2134

Closed
pixlwave opened this issue Nov 21, 2023 · 1 comment · Fixed by #2166
Closed

Cancelling Face ID no longer presents the PIN screen. #2134

pixlwave opened this issue Nov 21, 2023 · 1 comment · Fixed by #2166
Assignees
@pixlwave
Labels
A-App-Lock O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@pixlwave
Copy link
Member

Steps to reproduce

  1. Enable Screen lock with Face ID
  2. Background the app
  3. Foreground the app but put on a disguise 🥸
  4. Tap cancel when Face ID fails.

Outcome

What did you expect?

The PIN code screen to be presented.

What happened instead?

The Face ID prompt is shown again

The cause

When you hit cancel, the Face ID prompt is dismissed which triggers the app to become active which following on from #2026 is also the same trigger as when we begin the app lock flow. So you go round and round and round 🔄

Your phone model

iPhone 12

Operating system version

iOS 17

Application version

1.4.2

Homeserver

No response

Will you send logs?

No
@pixlwave pixlwave added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-App-Lock labels Nov 21, 2023
@pixlwave pixlwave self-assigned this Nov 21, 2023
@pixlwave pixlwave mentioned this issue Nov 24, 2023
Merged
@pixlwave
Copy link
Member Author

pixlwave commented Nov 24, 2023 •
edited
Loading

Fixed by #2166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixlwave pixlwave

Labels
A-App-Lock O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a state machine to AppLockFlowCoordinator. element-hq/element-x-ios
2 participants
@kittykat @pixlwave