Add a state machine to AppLockFlowCoordinator. #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Generated by 🚫 Danger Swift against 28d94e0 |
stefanceriu
approved these changes
Nov 24, 2023
Fixes a bug when cancelling Face ID would loop back round to presenting Face ID.
- UI tests initial expectations. - Unit tests compile error.
pixlwave
force-pushed
the
doug/app-lock-state
branch
from
d355569 to
28d94e0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cancelling Face ID would loop back round and present the Face ID prompt again when becoming active. Fixing that revealed a few more edge cases one-by-one so I added a state machine to drive the flow instead.
Fixes #2134.
AppLock.mp4