Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite had no accept button #2840

Closed
ara4n opened this issue May 16, 2024 · 4 comments
Closed

Invite had no accept button #2840

ara4n opened this issue May 16, 2024 · 4 comments
Labels
A-Invite O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Backend

Comments

@ara4n
Copy link
Member

ara4n commented May 16, 2024

Steps to reproduce

  1. Tapped on a push notif, invite from the CVE bot
  2. Saw this:

IMG_6601

Outcome

What did you expect?

Accept/Reject style buttons

What happened instead?

No buttons. I went back to the roomlist; invite wasn't there (perhaps SS hadn't synced?); waited

Your phone model

iPhone 12 Pro Max

Operating system version

No response

Application version

597

Homeserver

No response

Will you send logs?

Yes

@ara4n ara4n added the T-Defect label May 16, 2024
@ara4n
Copy link
Member Author

ara4n commented May 16, 2024

arguably this is an improvement on #2773 but not much ;P

@Velin92 Velin92 added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue A-Invite X-Needs-Backend S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jun 3, 2024
@manuroe
Copy link
Member

manuroe commented Jul 4, 2024

We need to test first that /room_summary API is working on m.org.

@stefanceriu
Copy link
Member

stefanceriu commented Jul 18, 2024

We need to test first that /room_summary API is working on m.org.

Does not look like it's enabled https://matrix-client.matrix.org/_matrix/client/versions

Nevermind, it works just fine https://matrix-client.matrix.org/_matrix/client/unstable/im.nheko.summary/rooms/!amwlFMejXQcoCxNYHH:matrix.org/summary

{
room_id: "!amwlFMejXQcoCxNYHH:matrix.org",
name: "Element X iOS",
topic: "Discussions about Element X iOS | https://github.com/vector-im/element-x-ios

Feature Status: https://github.com/vector-im/element-x-ios/issues/1225

App Store: https://apple.co/3r6LJHZ
TestFlight: https://testflight.apple.com/join/uZbeZCOi",
canonical_alias: "#element-x-ios:matrix.org",
num_joined_members: 598,
avatar_url: "mxc://matrix.org/EqEqCHUnpkIqbtrtLCxieErR",
join_rule: "public",
world_readable: true,
guest_can_join: false,
im.nheko.summary.version: "10"
}

@stefanceriu
Copy link
Member

Okay, I have finally figure out what's happening

  • the room summary API is indeed enabled on matrix.org and working fine for most rooms
  • it is not however capable of giving us data about non-joined + private rooms
  • the SDK addresses that by first trying to use known rooms before resorting to the preview endpoint
  • that fails if it's a brand new room that the client doesn't know about yet i.e. a sync hasn't ran, which is exactly what's happening here

stefanceriu added a commit that referenced this issue Jul 18, 2024
…s to populate the join room screen

- the room summary API is indeed enabled on matrix.org and working fine for most rooms
- it is not however capable of giving us data about non-joined + private rooms
- the SDK addresses that by first trying to use known rooms before resorting to the preview endpoint
- that fails if it's a brand new room that the client doesn't know about yet i.e. a sync hasn't ran, which is exactly what's happening here
- the ClientProxy instead does wait for the room list to go into the first loaded before returning the room
stefanceriu added a commit that referenced this issue Jul 18, 2024
…s to populate the join room screen

- the room summary API is indeed enabled on matrix.org and working fine for most rooms
- it is not however capable of giving us data about non-joined + private rooms
- the SDK addresses that by first trying to use known rooms before resorting to the preview endpoint
- that fails if it's a brand new room that the client doesn't know about yet i.e. a sync hasn't ran, which is exactly what's happening here
- the ClientProxy instead does wait for the room list to go into the first loaded before returning the room
stefanceriu added a commit that referenced this issue Jul 18, 2024
…s to populate the join room screen

- the room summary API is indeed enabled on matrix.org and working fine for most rooms
- it is not however capable of giving us data about non-joined + private rooms
- the SDK addresses that by first trying to use known rooms before resorting to the preview endpoint
- that fails if it's a brand new room that the client doesn't know about yet i.e. a sync hasn't ran, which is exactly what's happening here
- the ClientProxy instead does wait for the room list to go into the first loaded before returning the room
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Invite O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Backend
Projects
None yet
Development

No branches or pull requests

4 participants