Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ElementCall] Video calling is broken #3041

Closed
stefanceriu opened this issue Jul 15, 2024 · 2 comments
Closed

[ElementCall] Video calling is broken #3041

stefanceriu opened this issue Jul 15, 2024 · 2 comments
Labels
A-Call O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@stefanceriu
Copy link
Member

After starting or joining a video call the web app not longer shows videos (incoming or outgoing) on the UI.

Sending video also doesn't work properly with the other side (Element web in this case) sometimes receiving the video, sometimes not

IMG_1734F70AB13C-1
IMG_99748778D547-1
@stefanceriu stefanceriu added A-Call T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 15, 2024
stefanceriu added a commit that referenced this issue Jul 16, 2024
@stefanceriu
Fixes #3041 - Video not rendering after starting or joinng a call
712d741 
- not completely sure why this happens but `reportOutgoingCall` interferes with how the WebView gets access to video streams
- the call itself isn't really necessary so removing it is the simplest way forward
@stefanceriu stefanceriu mentioned this issue Jul 16, 2024
Closed
stefanceriu added a commit that referenced this issue Jul 16, 2024
@stefanceriu
Fixes #3041 - Video not rendering after starting or joinng a call
9b84cbd 
- not completely sure why this happens but `reportOutgoingCall` interferes with how the WebView gets access to video streams
- the call itself isn't really necessary so removing it is the simplest way forward
stefanceriu added a commit that referenced this issue Jul 16, 2024
@stefanceriu
Fixes #3041 - Video not rendering after starting or joinng a call
4e0376c 
- not completely sure why this happens but `reportOutgoingCall` interferes with how the WebView gets access to video streams
- the call itself isn't really necessary so removing it is the simplest way forward
@stefanceriu
Copy link
Member Author

Reopening this as videos still go missing when the call is started in response to an incoming CallKit notification.

@stefanceriu stefanceriu reopened this Jul 20, 2024
@stefanceriu
Copy link
Member Author

Transcript from the internal room:

I'm not sure what's happening but I went and removed all the CallKit related code except for what's making it ring e.g. https://github.com/element-hq/element-x-ios/blob/develop/ElementX/Sources/Services/ElementCall/ElementCallService.swift#L155-L161`
I also disconnected the CallKit ringing from the starting of the widget and the web view what I'm seeing is that as soon as CallKit establishes a call session the WebApp is unable to render the video once CallKit goes away it all goes back to normal
All I can think of is that CallKit messes with the streams in some way that prevents the WebApp from accessing them but I have no way to debug any of that

stefanceriu added a commit that referenced this issue Jul 22, 2024
@stefanceriu
Fixes #3041 - ElementCall unable to access media on ongoing CallKit s…
cd1a60e 
…ession.
@stefanceriu stefanceriu mentioned this issue Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Call O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefanceriu