Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite again user on direct chats #1087

Merged
merged 9 commits into from
Jun 16, 2023
Merged

Conversation

alfogrillo
Copy link
Contributor

Fix #1077

Room Room details
d d2

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L121 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L361 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

Generated by 🚫 Danger Swift against 1cc5cb7

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 32.00% and project coverage change: -0.05 ⚠️

Comparison is base (de0213a) 44.02% compared to head (ae88b70) 43.98%.

❗ Current head ae88b70 differs from pull request most recent head 1cc5cb7. Consider uploading reports for the commit 1cc5cb7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1087      +/-   ##
===========================================
- Coverage    44.02%   43.98%   -0.05%     
===========================================
  Files          384      384              
  Lines        24295    24367      +72     
  Branches     12806    12834      +28     
===========================================
+ Hits         10696    10717      +21     
- Misses       13318    13367      +49     
- Partials       281      283       +2     
Flag Coverage Δ
unittests 23.87% <32.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ens/RoomDetailsScreen/View/RoomDetailsScreen.swift 52.11% <0.00%> (-0.85%) ⬇️
...entX/Sources/Services/Room/RoomProxyProtocol.swift 56.52% <0.00%> (-11.90%) ⬇️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 44.60% <31.81%> (-1.95%) ⬇️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 49.88% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo marked this pull request as ready for review June 15, 2023 14:13
@alfogrillo alfogrillo requested a review from a team as a code owner June 15, 2023 14:13
@alfogrillo alfogrillo requested review from pixlwave and removed request for a team June 15, 2023 14:13
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice UX improvement 👍
Various comments but nothing major :)

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep yep, looks good 🚢

@alfogrillo alfogrillo force-pushed the alfogrillo/reinvite_dm branch from ae88b70 to 1cc5cb7 Compare June 16, 2023 13:22
@alfogrillo alfogrillo enabled auto-merge (squash) June 16, 2023 13:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo merged commit 87b0d95 into develop Jun 16, 2023
@alfogrillo alfogrillo deleted the alfogrillo/reinvite_dm branch June 16, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve leaving a DM experience
2 participants