Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localizations to UI tests target #118

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

ismailgulek
Copy link
Contributor

Fixes #101

@ismailgulek ismailgulek requested review from a team and pixlwave and removed request for a team June 29, 2022 14:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 02553e5

@github-actions
Copy link

Changes in 118 (2022-06-29)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • Settings screen minimal implementation. (#37)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)
  • Room timeline: Add plain styler and add timeline option in settings screen. (#92)
  • Implement and use background tasks. (#99)

🙌 Improvements

  • Room: Use bubbles in the timeline. (#34)
  • Room: Add header view containing room avatar and encryption badge. (#35)
  • Add a the splash screen and login screen from Element iOS along with a UserSessionStore. (#40)
  • DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)
  • Settings: Auto dismiss bug report screen and show a success indicator when bug report completed. (#76)
  • Bug report: Add GH labels. (#77)
  • Danger: Add a check for png files and warn to use SVG and PDF files. (#87)
  • Add localizations to UI tests target and add some checks. (#101)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

  • Use v0.0.1 of the DesignTokens package. (#78)
  • Update to v0.0.2 of the DesignTokens package. (#90)
  • Fix Danger's changelog detection. (#74)

Others

  • Fix project urls in Towncrier configuration. (#96)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VjxDvZ

@codecov-commenter
Copy link

Codecov Report

Merging #118 (02553e5) into develop (dbee192) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #118      +/-   ##
===========================================
- Coverage    27.13%   27.12%   -0.02%     
===========================================
  Files          148      148              
  Lines        10588    10578      -10     
  Branches      5194     5188       -6     
===========================================
- Hits          2873     2869       -4     
+ Misses        7631     7626       -5     
+ Partials        84       83       -1     
Impacted Files Coverage Δ
ElementX/Sources/Generated/Strings.swift 2.03% <100.00%> (ø)
ElementX/Sources/Other/Extensions/Bundle.swift 100.00% <100.00%> (+20.68%) ⬆️
...urces/Screens/SplashScreen/View/SplashScreen.swift 79.87% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbee192...02553e5. Read the comment docs.

@ismailgulek ismailgulek merged commit 7bd4763 into develop Jun 29, 2022
@ismailgulek ismailgulek deleted the ismail/101_simplify_localization branch June 29, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use localized strings in UI tests
3 participants