Add SwiftFormat to the project. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in 129 (2022-07-06)✨ Features
🙌 Improvements
🐛 Bugfixes
🧱 Build
Others
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NUwDSY |
pixlwave
force-pushed
the
doug/swiftformat
branch
from
c961339 to
70faaeb
Compare
pixlwave
changed the title
Generated by 🚫 Danger Swift against 22f2591 |
pixlwave
force-pushed
the
doug/swiftformat
branch
2 times, most recently
from
8ade9ac to
70aaf9c
Compare
ismailgulek
reviewed
Jul 5, 2022
ismailgulek
reviewed
Jul 5, 2022
ismailgulek
reviewed
Jul 5, 2022
ismailgulek
reviewed
Jul 5, 2022
ElementX/Sources/Services/SessionVerification/MockSessionVerificationControllerProxy.swift
Outdated
Show resolved
Hide resolved
ismailgulek
reviewed
Jul 5, 2022
ismailgulek
reviewed
Jul 5, 2022
ElementX/Sources/AppDelegate.swift
Outdated
| @@ -15,8 +15,8 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
|
|
|||
| func application(_ application: UIApplication, willFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool { | |||
|
|
|||
| // fixme: Use `Bundle.elementLanguage = ".."` when we have the functionality | |||
| // use `en` as fallback language | |||
| // FIXME: Use `Bundle.elementLanguage = ".."` when we have the functionality | |||
There was a problem hiding this comment.
We could remove this at all.
ismailgulek
reviewed
Jul 5, 2022
pixlwave
commented
Jul 5, 2022
ElementX/Sources/Services/SessionVerification/MockSessionVerificationControllerProxy.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/AppDelegate.swift
Outdated
| @@ -15,8 +15,8 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
|
|
|||
| func application(_ application: UIApplication, willFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool { | |||
|
|
|||
| // fixme: Use `Bundle.elementLanguage = ".."` when we have the functionality | |||
| // use `en` as fallback language | |||
| // FIXME: Use `Bundle.elementLanguage = ".."` when we have the functionality | |||
Codecov Report
@@ Coverage Diff @@
## develop #129 +/- ##
========================================
Coverage 35.57% 35.58%
========================================
Files 166 166
Lines 11524 11498 -26
Branches 5635 5631 -4
========================================
- Hits 4100 4091 -9
+ Misses 7333 7316 -17
Partials 91 91
Continue to review full report at Codecov.
|
pixlwave
force-pushed
the
doug/swiftformat
branch
from
c6af245 to
e47369a
Compare
pixlwave
changed the title
pixlwave
force-pushed
the
doug/swiftformat
branch
from
bbd92a4 to
22f2591
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Kudos, SonarCloud Quality Gate passed!
|
ismailgulek
approved these changes
Jul 6, 2022
This was referenced Jul 6, 2022
Merged
Closed
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SwiftFormat to the project as a build phase and runs it for the first time. I've gone for a regular pre-build phase on the main target which the docs don't particularly recommend (instead suggesting to use a step on the tests target). Seems like this should be ok for now, but happy to update now if deemed sensible.
Another option would be to never run manually, instead using Danger to inform you to run it on a PR.