Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating members after an ignore/unignore action has been performed. #1327

Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 14, 2023

@Velin92 Velin92 requested a review from a team as a code owner July 14, 2023 12:32
@Velin92 Velin92 requested review from pixlwave and removed request for a team July 14, 2023 12:32
@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against bc7eccd

@Velin92 Velin92 linked an issue Jul 14, 2023 that may be closed by this pull request
@Velin92 Velin92 force-pushed the mauroromito/fix_for_UI_not_keeping_the_state_of_ignored_user branch from d569243 to 600c563 Compare July 14, 2023 12:39
@Velin92 Velin92 requested a review from alfogrillo July 14, 2023 12:43
@Velin92 Velin92 force-pushed the mauroromito/fix_for_UI_not_keeping_the_state_of_ignored_user branch from c1b463a to 99582f8 Compare July 14, 2023 12:58
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 42.10% and project coverage change: -0.01 ⚠️

Comparison is base (b31af77) 44.29% compared to head (47066b2) 44.29%.

❗ Current head 47066b2 differs from pull request most recent head bc7eccd. Consider uploading reports for the commit bc7eccd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1327      +/-   ##
===========================================
- Coverage    44.29%   44.29%   -0.01%     
===========================================
  Files          399      399              
  Lines        26526    26537      +11     
  Branches     13481    13487       +6     
===========================================
+ Hits         11750    11754       +4     
- Misses       14475    14481       +6     
- Partials       301      302       +1     
Flag Coverage Δ
unittests 22.59% <42.10%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 42.64% <0.00%> (-0.24%) ⬇️
...ilsScreen/RoomMemberDetailsScreenCoordinator.swift 72.72% <0.00%> (-27.28%) ⬇️
...erDetailsScreen/View/RoomMemberDetailsScreen.swift 56.62% <0.00%> (ø)
...rListScreen/RoomMembersListScreenCoordinator.swift 41.93% <0.00%> (ø)
...berListScreen/RoomMembersListScreenViewModel.swift 81.48% <ø> (-0.23%) ⬇️
...tailsScreen/RoomMemberDetailsScreenViewModel.swift 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Velin92 Velin92 force-pushed the mauroromito/fix_for_UI_not_keeping_the_state_of_ignored_user branch from 99582f8 to 64c37a4 Compare July 14, 2023 14:55
@Velin92 Velin92 force-pushed the mauroromito/fix_for_UI_not_keeping_the_state_of_ignored_user branch from 64c37a4 to 47066b2 Compare July 17, 2023 08:30
Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Velin92 Velin92 force-pushed the mauroromito/fix_for_UI_not_keeping_the_state_of_ignored_user branch from e871d4b to bc7eccd Compare July 17, 2023 10:40
@Velin92 Velin92 enabled auto-merge (squash) July 17, 2023 10:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
19.0% 19.0% Duplication

@Velin92 Velin92 merged commit 2baeb13 into develop Jul 17, 2023
@Velin92 Velin92 deleted the mauroromito/fix_for_UI_not_keeping_the_state_of_ignored_user branch July 17, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocking a user does not retain state in UI until back in the room
3 participants