Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the app version and the device ID copyable in the Settings screen. #1389

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Make the app version and the device ID copyable in the Settings screen. #1389

merged 3 commits into from
Jul 25, 2023

Conversation

pixlwave
Copy link
Member

Fixes #623

@pixlwave pixlwave requested a review from a team as a code owner July 24, 2023 11:52
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 24, 2023 11:52
@pixlwave pixlwave enabled auto-merge (squash) July 24, 2023 11:52
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 1e5a7c9

@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.47% 🎉

Comparison is base (9f4479b) 44.83% compared to head (2502c91) 45.30%.

❗ Current head 2502c91 differs from pull request most recent head 1e5a7c9. Consider uploading reports for the commit 1e5a7c9 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1389      +/-   ##
===========================================
+ Coverage    44.83%   45.30%   +0.47%     
===========================================
  Files          389      387       -2     
  Lines        24886    24700     -186     
  Branches     12694    12593     -101     
===========================================
+ Hits         11157    11191      +34     
+ Misses       13445    13223     -222     
- Partials       284      286       +2
Flag Coverage Δ
unittests 22.89% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Settings/SettingsScreen/View/SettingsScreen.swift 73.29% <0.00%> (-0.85%) ⬇️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Velin92
Velin92 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one comment

@pixlwave pixlwave force-pushed the doug/623-copy-version-and-id branch from 2502c91 to 1e5a7c9 Compare July 25, 2023 17:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave merged commit 7a9edc5 into develop Jul 25, 2023
@pixlwave pixlwave deleted the doug/623-copy-version-and-id branch July 25, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't copypaste version or device id
2 participants
@pixlwave @Velin92