FF to enable filtering notifications by push rules #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against b6b9268 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1412 +/- ##
===========================================
+ Coverage 45.49% 45.91% +0.42%
===========================================
Files 396 394 -2
Lines 25667 25514 -153
Branches 13027 12976 -51
===========================================
+ Hits 11678 11716 +38
+ Misses 13695 13500 -195
- Partials 294 298 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Velin92
force-pushed
the
mauroromito/FF_push_context_filtering
branch
from
e3a8e45 to
b6b9268
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that notifications do a small sliding sync when received, they should be able to get the push rules and filter automatically.
Since this is experimental, this needs to be enabled as a FF.