Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatars and Usernames color change #1610

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 31, 2023

  • New color for avatars and username.
  • Also the font of the placeholder is now computed proportionally to the encapsulating view.
  • Placeholder in notifications is also going to be updated
  • This also fixes the misalignment between web and el-x (when web will support the new colouring system ofc)

I might need to update all the UI tests.

Simulator Screenshot - iPhone 14 - 2023-08-31 at 20 06 07
Simulator Screenshot - iPhone 14 - 2023-08-31 at 20 05 48

fixes #1603

Part of element-hq/compound#137

@Velin92 Velin92 requested a review from a team as a code owner August 31, 2023 18:11
@Velin92 Velin92 requested review from alfogrillo and amshakal and removed request for a team August 31, 2023 18:11
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7117ac2

@Velin92 Velin92 requested a review from pixlwave August 31, 2023 18:12
@Velin92 Velin92 force-pushed the mauroromito/updated_avatar_colors branch from 486b6e7 to a2809c1 Compare August 31, 2023 18:14
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16% ⚠️

Comparison is base (6df74aa) 57.68% compared to head (c06e284) 57.53%.

❗ Current head c06e284 differs from pull request most recent head 7117ac2. Consider uploading reports for the commit 7117ac2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1610      +/-   ##
===========================================
- Coverage    57.68%   57.53%   -0.16%     
===========================================
  Files          410      410              
  Lines        27673    27662      -11     
  Branches     13729    13721       -8     
===========================================
- Hits         15964    15915      -49     
- Misses       11264    11304      +40     
+ Partials       445      443       -2     
Flag Coverage Δ
unittests 22.80% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
DesignKit/Sources/Colors/ElementColors.swift 100.00% <ø> (ø)
...entX/Sources/Other/EffectsScene/EffectsScene.swift 0.00% <0.00%> (ø)
...urces/Other/Extensions/UNNotificationContent.swift 0.00% <0.00%> (ø)
...s/Other/SwiftUI/Views/PlaceholderAvatarImage.swift 47.27% <0.00%> (-11.22%) ⬇️
...een/View/Style/TimelineItemBubbledStylerView.swift 67.55% <0.00%> (-0.30%) ⬇️
...creen/View/Style/TimelineItemPlainStylerView.swift 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 linked an issue Sep 1, 2023 that may be closed by this pull request
@Velin92 Velin92 force-pushed the mauroromito/updated_avatar_colors branch from 51b6c5f to e28971b Compare September 1, 2023 07:51
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look sooo good. Thank you for taking the time to implement this 🙌

DesignKit/Sources/Colors/ElementColors.swift Outdated Show resolved Hide resolved
project.yml Show resolved Hide resolved
Velin92 and others added 3 commits September 1, 2023 10:10
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
@Velin92 Velin92 enabled auto-merge (squash) September 1, 2023 09:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit 38d6ffb into develop Sep 1, 2023
@Velin92 Velin92 deleted the mauroromito/updated_avatar_colors branch September 1, 2023 09:28
Copy link

@amshakal amshakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fast!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New avatars placeholder colors and username coloring Placeholder avatars are 'wrong' colour.
3 participants