Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various accessibility fixes #1694

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Various accessibility fixes #1694

merged 8 commits into from
Sep 13, 2023

Conversation

stefanceriu
Copy link
Member

  • add labels on timeline media
  • hide swipe to reply button
  • add sender on all messages
  • improve replies and reactions

@stefanceriu stefanceriu requested a review from a team as a code owner September 13, 2023 08:24
@stefanceriu stefanceriu requested review from Velin92 and pixlwave and removed request for a team and Velin92 September 13, 2023 08:24
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against eda81a9

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (dc5514b) 59.31% compared to head (eda81a9) 59.22%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1694      +/-   ##
===========================================
- Coverage    59.31%   59.22%   -0.09%     
===========================================
  Files          414      414              
  Lines        28473    28503      +30     
  Branches     14165    14175      +10     
===========================================
- Hits         16888    16881       -7     
- Misses       11125    11162      +37     
  Partials       460      460              
Flag Coverage Δ
unittests 22.68% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ns/RoomScreen/View/Replies/TimelineReplyView.swift 28.99% <0.00%> (-0.18%) ⬇️
...een/View/Style/TimelineItemBubbledStylerView.swift 66.95% <0.00%> (-1.80%) ⬇️
...een/View/Supplementary/TimelineReactionsView.swift 68.42% <0.00%> (-1.05%) ⬇️
...omScreen/View/Timeline/AudioRoomTimelineView.swift 0.00% <0.00%> (ø)
...oomScreen/View/Timeline/FileRoomTimelineView.swift 0.00% <0.00%> (ø)
...omScreen/View/Timeline/ImageRoomTimelineView.swift 0.00% <0.00%> (ø)
...creen/View/Timeline/LocationRoomTimelineView.swift 0.00% <0.00%> (ø)
...Screen/View/Timeline/StickerRoomTimelineView.swift 0.00% <0.00%> (ø)
...omScreen/View/Timeline/VideoRoomTimelineView.swift 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit f96969a into develop Sep 13, 2023
@stefanceriu stefanceriu deleted the stefan/1104 branch September 13, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants