Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeline properties for edited and reactions. #183

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

pixlwave
Copy link
Member

Not yet visible, waiting for timeline API. Also not really themed, can be done as part of #177.

Part of #111.

Bubbles Plain
Screenshot 2022-09-14 at 10 45 41 am Screenshot 2022-09-14 at 10 45 03 am

Not yet visible, waiting for timeline API.
@pixlwave pixlwave requested review from a team and ismailgulek and removed request for a team September 14, 2022 09:49
@github-actions
Copy link

github-actions bot commented Sep 14, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against ee33153

@github-actions
Copy link

github-actions bot commented Sep 14, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hnVEuQ

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 12.89% // Head: 12.76% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (ee33153) compared to base (2986f85).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
- Coverage    12.89%   12.76%   -0.13%     
===========================================
  Files          187      194       +7     
  Lines        12386    12509     +123     
  Branches      5987     6042      +55     
===========================================
  Hits          1597     1597              
- Misses       10749    10872     +123     
  Partials        40       40              
Impacted Files Coverage Δ
...urces/Other/SwiftUI/Layout/AlignedScrollView.swift 0.00% <0.00%> (ø)
...Sources/Other/SwiftUI/Layout/ViewFrameReader.swift 0.00% <0.00%> (ø)
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 0.00% <ø> (ø)
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 0.00% <0.00%> (ø)
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 0.00% <0.00%> (ø)
...een/View/Style/TimelineItemBubbledStylerView.swift 0.00% <0.00%> (ø)
...creen/View/Style/TimelineItemPlainStylerView.swift 0.00% <0.00%> (ø)
...een/View/Supplementary/TimelineReactionsView.swift 0.00% <0.00%> (ø)
...omScreen/View/Timeline/EmoteRoomTimelineView.swift 0.00% <0.00%> (ø)
...s/RoomScreen/View/Timeline/FormattedBodyText.swift 0.00% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👏

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave merged commit 4bed534 into develop Sep 14, 2022
@pixlwave pixlwave deleted the doug/reactions branch September 14, 2022 11:19
@pixlwave pixlwave removed the request for review from ismailgulek September 14, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants