Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1864 - Message forwarding room list filtering and pagination problems #1867

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Oct 9, 2023

  • use a separate room summary provider instance just for message forwarding
  • filter rooms through the rust sdk
  • add pagination support

Fixes #1864

@stefanceriu stefanceriu requested a review from a team as a code owner October 9, 2023 08:53
@stefanceriu stefanceriu requested review from alfogrillo and pixlwave and removed request for a team and alfogrillo October 9, 2023 08:53
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 26025e6

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (8270a86) 70.55% compared to head (26025e6) 70.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1867      +/-   ##
===========================================
+ Coverage    70.55%   70.60%   +0.04%     
===========================================
  Files          452      452              
  Lines        30756    30793      +37     
  Branches     15065    15088      +23     
===========================================
+ Hits         21701    21741      +40     
+ Misses        8506     8503       -3     
  Partials       549      549              
Flag Coverage Δ
unittests 54.53% <38.70%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ElementX/Sources/Other/Extensions/Bundle.swift 78.57% <100.00%> (+2.57%) ⬆️
...arsing/DTHTMLElement+AttributedStringBuilder.swift 76.19% <ø> (-4.21%) ⬇️
...rwardingScreen/MessageForwardingScreenModels.swift 100.00% <ø> (ø)
...orwardingScreen/View/MessageForwardingScreen.swift 91.25% <100.00%> (+1.10%) ⬆️
.../Sources/Services/Client/ClientProxyProtocol.swift 0.00% <ø> (ø)
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 54.74% <0.00%> (ø)
ElementX/Sources/Services/Client/ClientProxy.swift 45.97% <0.00%> (-0.78%) ⬇️
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 62.64% <0.00%> (-2.04%) ⬇️
...rdingScreen/MessageForwardingScreenViewModel.swift 73.03% <35.71%> (-17.14%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu enabled auto-merge (squash) October 9, 2023 11:59
@stefanceriu stefanceriu disabled auto-merge October 9, 2023 11:59
@stefanceriu stefanceriu merged commit 1f12a7c into develop Oct 9, 2023
@stefanceriu stefanceriu deleted the stefan/1864 branch October 9, 2023 11:59
@stefanceriu stefanceriu changed the title Fixes 1864 - Message forwarding room list filtering and pagination problems Fixes #1864 - Message forwarding room list filtering and pagination problems Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forwarded messages doesn't work.
2 participants