-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable VoiceOver in timeline menu #1907
Conversation
Generated by 🚫 Danger Swift against a0f042d |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1907 +/- ##
===========================================
- Coverage 70.91% 70.91% -0.01%
===========================================
Files 464 464
Lines 31468 31467 -1
Branches 15355 15355
===========================================
- Hits 22316 22315 -1
Misses 8588 8588
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Ohhhh interesting. So whilst screen was completely broken (🙈), I'm not sure these changes end up helping the user that much as you also can't access this sheet via VoiceOver. If it's within scope for you, we should probably be adding support for all the actions in the rotor. I don't think it would end up being too different from how we build the mac context menu in terms of how it fits in. Related issue: #660 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops I clicked the wrong one before.
50225e6
to
a0f042d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I think we technically can (I did it), but the trigger (the long press) will be still difficult to action for blind people. 😕
Nope, I think it's out of scope. I wanted at least to have the VoiceOver reading the options in the menu like EXA is doing. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Enabled the voice over on the timeline menu to align to EX Android (more context is here)