Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom copy for notifications that contain mentions #2050

Merged
merged 12 commits into from
Nov 9, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 8, 2023

fixes #1825

ima_0ed5ddd

@Velin92 Velin92 requested a review from a team as a code owner November 8, 2023 18:33
@Velin92 Velin92 requested review from pixlwave and removed request for a team November 8, 2023 18:33
Copy link

github-actions bot commented Nov 8, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 9678829

@Velin92 Velin92 marked this pull request as draft November 8, 2023 18:36
@Velin92 Velin92 marked this pull request as ready for review November 9, 2023 14:32
@Velin92 Velin92 requested a review from stefanceriu November 9, 2023 15:51
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (019ca62) 69.58% compared to head (32a9428) 69.61%.

❗ Current head 32a9428 differs from pull request most recent head 9678829. Consider uploading reports for the commit 9678829 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2050      +/-   ##
===========================================
+ Coverage    69.58%   69.61%   +0.02%     
===========================================
  Files          521      522       +1     
  Lines        36177    36173       -4     
  Branches     17507    17494      -13     
===========================================
+ Hits         25173    25181       +8     
+ Misses       10346    10330      -16     
- Partials       658      662       +4     
Flag Coverage Δ
unittests 54.56% <30.30%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ElementX/Sources/Application/AppSettings.swift 96.72% <ø> (-0.06%) ⬇️
...X/Sources/Application/CommonConstantSettings.swift 100.00% <100.00%> (ø)
...fication/Proxy/NotificationItemProxyProtocol.swift 0.00% <ø> (ø)
.../Sources/Services/Media/Provider/MediaLoader.swift 84.31% <0.00%> (ø)
...Services/SecureBackup/SecureBackupController.swift 36.36% <0.00%> (-0.88%) ⬇️
...rvices/VoiceMessage/VoiceMessageMediaManager.swift 84.14% <60.00%> (-1.93%) ⬇️
...entX/Sources/Other/Pills/PlainMentionBuilder.swift 0.00% <0.00%> (ø)
...ces/Notification/Proxy/NotificationItemProxy.swift 0.00% <0.00%> (ø)
...urces/Other/Extensions/UNNotificationContent.swift 0.00% <0.00%> (ø)
...Services/Media/Provider/MediaFileHandleProxy.swift 63.33% <36.36%> (-22.39%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 requested a review from pixlwave November 9, 2023 17:48
@Velin92 Velin92 enabled auto-merge (squash) November 9, 2023 17:48
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@Velin92 Velin92 merged commit a4bc7b8 into develop Nov 9, 2023
@Velin92 Velin92 deleted the mauroromito/custom_copy_for_mentioning_notifications branch November 9, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentions: Push notifications display user mentions differently
4 participants