Fix: added sample rate conversion for recording voice messages #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against f76b3a5 |
|
Kudos, SonarCloud Quality Gate passed!
|
stefanceriu
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2184
This crash was due to a sample rate (44100) that doesn't seem to be supported by
opus_encoder_create.The default sample rate has changed between iPhone X and iPhone 11. Since iPhone 11, the default sample rate when recording is
48000(it was44100).The fix is to use
AVAudioConverterto convert the audio buffer to the correct sample rate (48000).Recording and sending a voice message now works correctly: