Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process InfoPlist.strings in Localazy config. #2249

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 14, 2023

Also merge the 2 configs into one using a group to download all strings.

Closes #2100

It works 🎉
Screenshot 2023-12-14 at 6 01 08 pm

@pixlwave pixlwave requested a review from a team as a code owner December 14, 2023 16:54
@pixlwave pixlwave requested review from nimau and removed request for a team December 14, 2023 16:54
Copy link

github-actions bot commented Dec 14, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against bdc2324

@pixlwave pixlwave force-pushed the doug/info-plist-strings branch from 644b2d9 to 9224d41 Compare December 14, 2023 17:05
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also merge the 2 configs into one using a group to download all strings.
@pixlwave pixlwave force-pushed the doug/info-plist-strings branch from 9224d41 to 757ed32 Compare December 14, 2023 18:17
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave merged commit af562ea into develop Dec 15, 2023
4 checks passed
@pixlwave pixlwave deleted the doug/info-plist-strings branch December 15, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup support for multiple files from Localazy
2 participants