Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered out unwanted state events for DMs #2361

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 19, 2024

fixes #2329
Simulator Screenshot - iPhone 15 - 2024-01-19 at 18 00 55

@Velin92 Velin92 requested a review from a team as a code owner January 19, 2024 17:01
@Velin92 Velin92 requested review from stefanceriu and pixlwave and removed request for a team January 19, 2024 17:01
Copy link

github-actions bot commented Jan 19, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 6cb6521

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a64ad5d) 73.10% compared to head (6cb6521) 72.99%.

Files Patch % Lines
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% 7 Missing ⚠️
...ne/TimelineController/RoomTimelineController.swift 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2361      +/-   ##
===========================================
- Coverage    73.10%   72.99%   -0.11%     
===========================================
  Files          513      513              
  Lines        35405    35413       +8     
  Branches     17010    17016       +6     
===========================================
- Hits         25882    25850      -32     
- Misses        8899     8941      +42     
+ Partials       624      622       -2     
Flag Coverage Δ
unittests 57.81% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@Velin92 Velin92 merged commit faeab89 into develop Jan 19, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/remove_unnecessary_state_events_for_DMs branch January 19, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the initial timeline items in DMs
2 participants