Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump SDK + Mention Badge fix #2367

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Bump SDK + Mention Badge fix #2367

merged 4 commits into from
Jan 22, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 22, 2024

This PR updates the SDK and fixes an issue with the mention badge not being unset properly when reading the message

@Velin92 Velin92 requested a review from a team as a code owner January 22, 2024 14:52
@Velin92 Velin92 requested review from pixlwave and removed request for a team January 22, 2024 14:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/HomeScreen/HomeScreenViewModel.swift#L336 - Line should be 250 characters or less: currently 257 characters (line_length)

Generated by 🚫 Danger Swift against bfb2682

pixlwave
pixlwave approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ElementX/Sources/Screens/RoomScreen/RoomScreenInteractionHandler.swift Show resolved Hide resolved
@Velin92 Velin92 mentioned this pull request Jan 22, 2024
Merged
@Velin92 Velin92 enabled auto-merge (squash) January 22, 2024 15:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 merged commit dd28261 into develop Jan 22, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/mention_badge_fix branch January 22, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @pixlwave