Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tweaks #2421

Merged
merged 3 commits into from
Feb 6, 2024
Merged

CI tweaks #2421

merged 3 commits into from
Feb 6, 2024

Conversation

stefanceriu
Copy link
Member

  • fix unit tests
  • fixed VStack warning
  • updated ruby dependencies

@stefanceriu stefanceriu requested a review from a team as a code owner February 6, 2024 07:30
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team February 6, 2024 07:30
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Feb 6, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 1b6f0c0

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98892c0) 72.87% compared to head (1b6f0c0) 72.80%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2421      +/-   ##
===========================================
- Coverage    72.87%   72.80%   -0.07%     
===========================================
  Files          523      523              
  Lines        36190    36190              
  Branches     17413    17413              
===========================================
- Hits         26372    26349      -23     
- Misses        9173     9201      +28     
+ Partials       645      640       -5     
Flag Coverage Δ
unittests 58.15% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu merged commit a241425 into develop Feb 6, 2024
9 checks passed
@stefanceriu stefanceriu deleted the stefan/CITweaks branch February 6, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants