Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new decorative colours. #2438

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Use new decorative colours. #2438

merged 3 commits into from
Feb 9, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 8, 2024

Adopts new decorative colours from Compound which gives us consistent avatar colours compared to develop.element.io. Requires element-hq/compound-ios#59

@pixlwave pixlwave requested a review from a team as a code owner February 8, 2024 19:43
@pixlwave pixlwave requested review from Velin92 and removed request for a team February 8, 2024 19:43
Copy link

github-actions bot commented Feb 8, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7b295b2

Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4ba7aa9) 72.97% compared to head (7b295b2) 72.78%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...s/Other/SwiftUI/Views/PlaceholderAvatarImage.swift 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2438      +/-   ##
===========================================
- Coverage    72.97%   72.78%   -0.20%     
===========================================
  Files          521      521              
  Lines        36040    36040              
  Branches     17283    17283              
===========================================
- Hits         26300    26231      -69     
- Misses        9101     9174      +73     
+ Partials       639      635       -4     
Flag Coverage Δ
unittests 58.22% <80.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pixlwave pixlwave merged commit cc1d9ca into develop Feb 9, 2024
5 checks passed
@pixlwave pixlwave deleted the doug/decorative-colours branch February 9, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants