-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RoomDetails for use (with RoomMemberDetails) in AvatarHeaderView. #2490
Conversation
Generated by 🚫 Danger Swift against f3152f7 |
Quality Gate passedIssues Measures |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2490 +/- ##
===========================================
- Coverage 73.06% 73.02% -0.04%
===========================================
Files 522 523 +1
Lines 36467 36520 +53
Branches 17498 17513 +15
===========================================
+ Hits 26645 26670 +25
- Misses 9189 9220 +31
+ Partials 633 630 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
As a precursor to implementing the sheet for banning users, this PR makes the following changes
RoomDetails
struct as an analogue toRoomMemberDetails
RoomDetailsScreen
but could potentially be used in more places in the future.AvatarHeaderView
to only accept a room or member details in the init to share the logic for configuring the avatar, title and subtitle.RoomProxy.displayName
property in favour of.name
which we get from sliding sync.Split into 2 commits for easier reviewing as the second commit contains a load of refactoring of mocks for
displayName
→name