-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add roles and permissions screen #2505
Conversation
Generated by 🚫 Danger Swift against 8a7f73e |
The screen hasn't been added to the flows yet.
48dcc52
to
cbff8b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2505 +/- ##
===========================================
+ Coverage 74.56% 74.79% +0.22%
===========================================
Files 526 529 +3
Lines 36835 36974 +139
Branches 17495 17495
===========================================
+ Hits 27466 27653 +187
+ Misses 9151 9103 -48
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
ElementX/Sources/Screens/RoomRolesAndPermissionsScreen/View/RoomRolesAndPermissionsScreen.swift
Outdated
Show resolved
Hide resolved
|
This only implements the screen, I'll implement the other screens and then assemble them together with a flow coordinator once they're all done.
This forms the basis for #2356 and #2358.