-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding flow coordinator and FTUE changes #2578
Onboarding flow coordinator and FTUE changes #2578
Conversation
dbc256f
to
ae35a65
Compare
Generated by 🚫 Danger Swift against 5d6edc0 |
3aadb0c
to
10e1ea7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2578 +/- ##
===========================================
- Coverage 75.94% 75.15% -0.79%
===========================================
Files 545 566 +21
Lines 37693 38806 +1113
Branches 17078 16940 -138
===========================================
+ Hits 28627 29166 +539
- Misses 9066 9640 +574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooo, finally an onboarding flow 👏
ElementX/Resources/Assets.xcassets/images/background-bottom-light.imageset/Contents.json
Outdated
Show resolved
Hide resolved
ElementX/Resources/Assets.xcassets/images/Alerts.imageset/Contents.json
Outdated
Show resolved
Hide resolved
ElementX/Sources/FlowCoordinators/OnboardingFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
.../Sources/Screens/Onboarding/IdentityConfirmationScreen/View/IdentityConfirmationScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/Onboarding/IdentityConfirmedScreen/View/IdentityConfirmedScreen.swift
Outdated
Show resolved
Hide resolved
.../Sources/Screens/Onboarding/IdentityConfirmationScreen/View/IdentityConfirmationScreen.swift
Outdated
Show resolved
Hide resolved
...eens/Onboarding/NotificationPermissionsScreen/NotificationPermissionsScreenCoordinator.swift
Show resolved
Hide resolved
...es/Screens/Onboarding/NotificationPermissionsScreen/View/NotificationPermissionsScreen.swift
Outdated
Show resolved
Hide resolved
10e1ea7
to
1fcbf5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, although I think you're missing the commit with the changes you were showing me to the flow?
ElementX/Sources/Screens/Onboarding/AnalyticsPromptScreen/View/AnalyticsPromptScreen.swift
Outdated
Show resolved
Hide resolved
...es/Screens/Onboarding/NotificationPermissionsScreen/View/NotificationPermissionsScreen.swift
Outdated
Show resolved
Hide resolved
PreviewTests/__Snapshots__/PreviewTests/test_analyticsPromptScreen-iPad-en-GB.1.png
Outdated
Show resolved
Hide resolved
Oh that's mega weird, the push failed and I didn't notice 🤔 It's up now. |
…the flows - consolidate app lock in the onboarding flow coordinator - cleanup the old session verification flows - allow the recovery key screen to be presented both modally and not
…e onboarding flows
- add bottom background to certain screens - change hero images to support green styles and fix default colors - switch new onboarding screns to the FullScreenDialog - disable interactive dismissal - update snapshots
- present the onboarding flow as a full screen model and faster - speed up how soon we show onboarding for identity confirmation based on stored settings - store the notification permissions onboarding user choice - push onboarding screens onto the stack instead of having them replace the root
eef7618
to
998d358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
ElementX/Sources/FlowCoordinators/OnboardingFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
...rces/Screens/Onboarding/IdentityConfirmationScreen/IdentityConfirmationScreenViewModel.swift
Outdated
Show resolved
Hide resolved
...rces/Screens/Onboarding/IdentityConfirmationScreen/IdentityConfirmationScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/EncryptedHistoryRoomTimelineView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineController/RoomTimelineController.swift
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
This PR introduces the following significant changes:
Designs here https://www.figma.com/file/qjs3RKuofeKzBRPnOmLo2a/OIDC-sign-in-with-QR-code?type=design&node-id=19-144144&mode=design&t=7MXZzQhzq8C3h2uv-0
Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-03-21.at.14.09.37.mp4