Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Search View #2585

Merged
merged 12 commits into from
Mar 21, 2024
Merged

Public Search View #2585

merged 12 commits into from
Mar 21, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Mar 20, 2024 •
edited
Loading

Part 1 of the task:
#2518

Next part is implementing pagination.

The PR also bumps the SDK and the RTE version

Simulator Screenshot - iPhone 15 - 2024-03-20 at 19 39 05

@Velin92 Velin92 requested a review from a team as a code owner March 20, 2024 11:57
@Velin92 Velin92 requested review from pixlwave and removed request for a team March 20, 2024 11:57
@Velin92 Velin92 marked this pull request as draft March 20, 2024 11:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Services/Client/ClientProxy.swift#L172 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)
⚠️

ElementX/Sources/Services/Client/ClientProxy.swift#L174 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)
⚠️

ElementX/Sources/Services/Client/ClientProxy.swift#L176 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

Generated by 🚫 Danger Swift against 40b58ff

@Velin92 Velin92 marked this pull request as ready for review March 20, 2024 18:36
@Velin92 Velin92 requested a review from stefanceriu March 20, 2024 18:36
@Velin92 Velin92 changed the title [WIP] Public Search View Public Search View Mar 20, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.45024% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 75.87%. Comparing base (9e6b6ba) to head (3ba23ea).
Report is 1 commits behind head on develop.

❗ Current head 3ba23ea differs from pull request most recent head 40b58ff. Consider uploading reports for the commit 40b58ff to get more accurate results

Files Patch % Lines
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 25 Missing ⚠️
...hScreen/RoomDirectorySearchScreenCoordinator.swift 0.00% 21 Missing ⚠️
...rchScreen/RoomDirectorySearchScreenViewModel.swift 65.45% 19 Missing ⚠️
...ators/UserSessionFlowCoordinatorStateMachine.swift 0.00% 8 Missing ⚠️
...DirectorySearchScreen/View/RoomDirectoryCell.swift 78.12% 7 Missing ⚠️
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 6 Missing ⚠️
...s/Screens/HomeScreen/View/HomeScreenRoomList.swift 25.00% 3 Missing ⚠️
...ces/Screens/HomeScreen/HomeScreenCoordinator.swift 0.00% 2 Missing ⚠️
...ySearchScreen/View/RoomDirectorySearchScreen.swift 93.10% 2 Missing ⚠️
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2585      +/-   ##
===========================================
- Coverage    75.87%   75.87%   -0.01%     
===========================================
  Files          545      552       +7     
  Lines        37686    37904     +218     
  Branches     17077    17078       +1     
===========================================
+ Hits         28594    28758     +164     
- Misses        9092     9146      +54
Flag Coverage Δ
unittests 60.83% <55.45%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pixlwave
pixlwave approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor comments :)

ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinatorStateMachine.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/RoomDirectorySearchScreen/RoomDirectorySearchScreenCoordinator.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/RoomDirectorySearchScreen/RoomDirectorySearchScreenModels.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/RoomDirectorySearchScreen/RoomDirectorySearchScreenModels.swift Outdated Show resolved Hide resolved
UITests/Sources/RoomDirectorySearchScreenScreenUITests.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/RoomDirectorySearchScreen/View/RoomDirectoryCell.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/RoomDirectorySearchScreen/View/RoomDirectorySearchScreen.swift Show resolved Hide resolved
ElementX/Sources/Screens/RoomDirectorySearchScreen/View/RoomDirectoryCell.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/RoomDirectorySearchScreen/View/RoomDirectoryCell.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/RoomDirectorySearch/RoomDirectorySearchProxyProtocol.swift Outdated Show resolved Hide resolved
Velin92 added 8 commits March 21, 2024 14:27
@Velin92
public search view implemented
3bd1d12 
search view

generated screens

navigation implemented

started to create the cells

fetching implemented

but the views are not appearing, not sure why yet

fix invisible cells

next step is to make the send a new request for each search change and implement the pagination through scrolling size
@Velin92
bump sdk, but it doesn't build
9d049bb
@Velin92
tests and bump of RTE
c8455dd
@Velin92
changelog
1c215df
@Velin92
removed unused tests
b4cadf8
@Velin92
improvement
0bf72d4
@Velin92
updated tests
015e2cd
@Velin92
update proj
9df4029
@Velin92 Velin92 force-pushed the mauroromito/public_search branch from f8cccf2 to 9df4029 Compare March 21, 2024 13:29
Velin92 and others added 4 commits March 21, 2024 14:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 enabled auto-merge (squash) March 21, 2024 14:32
@Velin92 Velin92 merged commit 562e5e7 into develop Mar 21, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/public_search branch March 21, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@stefanceriu stefanceriu Awaiting requested review from stefanceriu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @pixlwave