Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a UserProfileScreen for profiles of non-members. #2687

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

pixlwave
Copy link
Member

The PR is the first part of #2634. It makes the following changes:

  • Adds a UserProfileScreen which is a cut down version of the RoomMemberDetailsScreen.
  • Replaces the member details screen in the stack with the user profile screen when the user can't be found in the room.

Still required to close the task:

  • Handle external links with a different route and present the user profile screen directly in the user session flow.

@pixlwave pixlwave requested a review from a team as a code owner April 11, 2024 17:05
@pixlwave pixlwave requested review from stefanceriu and removed request for a team April 11, 2024 17:05
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.5% Duplication on New Code

See analysis details on SonarCloud

Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Services/Room/RoomMember/RoomMemberDetails.swift#L56 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Services/Room/RoomMember/RoomMemberDetails.swift#L57 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Services/Room/RoomMember/RoomMemberDetails.swift#L58 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

Generated by 🚫 Danger Swift against 1d691b9

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, 🚀 it!

@pixlwave pixlwave merged commit 5c9d097 into develop Apr 12, 2024
4 of 5 checks passed
@pixlwave pixlwave deleted the doug/user-profile-screen branch April 12, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants