Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User session state machine crashes #281

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Conversation

stefanceriu
Copy link
Member

  • Fix UserSession state machine crashes on foregrounding and add the bug report screen to it
  • Rename home screen actions

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against b49a3d8

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 36.50% // Head: 36.34% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (b49a3d8) compared to base (d398b96).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #281      +/-   ##
===========================================
- Coverage    36.50%   36.34%   -0.16%     
===========================================
  Files          215      215              
  Lines        14456    14519      +63     
  Branches      7144     7208      +64     
===========================================
  Hits          5277     5277              
- Misses        9049     9109      +60     
- Partials       130      133       +3     
Flag Coverage Δ
unittests 12.13% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ces/Screens/HomeScreen/HomeScreenCoordinator.swift 34.69% <0.00%> (ø)
...urces/UserSession/UserSessionFlowCoordinator.swift 0.00% <0.00%> (ø)
...ssion/UserSessionFlowCoordinatorStateMachine.swift 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanceriu stefanceriu merged commit b270b8a into develop Nov 2, 2022
@stefanceriu stefanceriu deleted the stefan/stateMachineCrashes branch November 2, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants