Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency Fixes #283

Merged
merged 9 commits into from
Nov 2, 2022
Merged

Concurrency Fixes #283

merged 9 commits into from
Nov 2, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Nov 2, 2022

  • Reviewed the places where we used @MainActor.
  • Moved Rust client operations into a dedicated concurrent queue, so made sure we don't use them on main thread.
  • Removed a couple of Task.detached operations

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 130c6e9

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@ismailgulek ismailgulek force-pushed the ismail/concurrency_fixes branch from c32587c to 130c6e9 Compare November 2, 2022 15:25
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 35.75% // Head: 35.88% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (72bdd90) compared to base (965569a).
Patch coverage: 6.80% of modified lines in pull request are covered.

❗ Current head 72bdd90 differs from pull request most recent head 130c6e9. Consider uploading reports for the commit 130c6e9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #283      +/-   ##
===========================================
+ Coverage    35.75%   35.88%   +0.13%     
===========================================
  Files          216      216              
  Lines        14801    14746      -55     
  Branches      7568     7529      -39     
===========================================
  Hits          5292     5292              
+ Misses        9359     9306      -53     
+ Partials       150      148       -2     
Impacted Files Coverage Δ
...ces/Background/BackgroundTaskServiceProtocol.swift 100.00% <ø> (ø)
ElementX/Sources/Services/Client/ClientProxy.swift 0.00% <0.00%> (ø)
...entX/Sources/Services/Client/MockClientProxy.swift 20.58% <0.00%> (ø)
...lementX/Sources/Services/Media/MediaProvider.swift 0.00% <0.00%> (ø)
...Sources/Services/Media/MediaProviderProtocol.swift 0.00% <ø> (ø)
ElementX/Sources/Services/Media/MediaSource.swift 0.00% <0.00%> (ø)
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% <0.00%> (ø)
...urces/Services/Timeline/RoomTimelineProvider.swift 0.00% <0.00%> (ø)
...s/Services/UserSessionStore/UserSessionStore.swift 0.00% <0.00%> (ø)
...urces/UserSession/UserSessionFlowCoordinator.swift 0.00% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ismailgulek ismailgulek merged commit f6a599a into develop Nov 2, 2022
@ismailgulek ismailgulek deleted the ismail/concurrency_fixes branch November 2, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants