Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Forgot PIN button to AppLockSetupPINScreen. #2833

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

pixlwave
Copy link
Member

Fixes #2688.

@pixlwave pixlwave requested a review from a team as a code owner May 13, 2024 11:04
@pixlwave pixlwave requested review from stefanceriu and removed request for a team May 13, 2024 11:04
Copy link

github-actions bot commented May 13, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against aa967a9

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.51%. Comparing base (52b6c25) to head (aa967a9).
Report is 5 commits behind head on develop.

Files Patch % Lines
...etupPINScreen/AppLockSetupPINScreenViewModel.swift 87.50% 3 Missing ⚠️
...ockSetupPINScreen/View/AppLockSetupPINScreen.swift 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2833      +/-   ##
===========================================
+ Coverage    73.45%   73.51%   +0.06%     
===========================================
  Files          584      584              
  Lines        41275    41294      +19     
===========================================
+ Hits         30320    30359      +39     
+ Misses       10955    10935      -20     
Flag Coverage Δ
unittests 61.94% <83.87%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit b7d492c into develop May 13, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/2688-reset-pin branch May 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: Screen lock: "Forgot Pin" Flow missing
2 participants