Add support for showing the native OS incoming call screen when starting new Element Calls #2862
Conversation
Generated by 🚫 Danger Swift against 364d02e |
| @@ -143,6 +143,7 @@ struct AttributedStringBuilder: AttributedStringBuilderProtocol { | |||
| attributedString.removeAttribute(.foregroundColor, range: .init(location: 0, length: attributedString.length)) | |||
| } | |||
|
|
|||
| // swiftlint:disable:next cyclomatic_complexity | |||
There was a problem hiding this comment.
Because we have a warning there? 🤔
| case senderDisplayName | ||
| } | ||
|
|
||
| let ElementCallServiceNotificationDiscardDelta = 10.0 |
There was a problem hiding this comment.
maybe let's put this into a ElementCallServiceConstants enum as a static let
There was a problem hiding this comment.
Why would that be better? 🤔
…ing new Element Calls
stefanceriu
force-pushed
the
stefan/voipRinging
branch
2 times, most recently
from
b973e44 to
219728c
Compare
…tear down the call on dismissal.
stefanceriu
force-pushed
the
stefan/voipRinging
branch
from
219728c to
364d02e
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2862 +/- ##
===========================================
- Coverage 74.34% 74.07% -0.28%
===========================================
Files 578 579 +1
Lines 40993 41116 +123
===========================================
- Hits 30477 30456 -21
- Misses 10516 10660 +144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Handle incoming VoIP calls, show the native OS call screen as per https://developer.apple.com/documentation/callkit/sending-end-to-end-encrypted-voip-calls
Defined through matrix-org/matrix-spec-proposals#4075
Fixes #2876
Requires matrix-org/matrix-rust-sdk#3434
The way this works is the following:
reportNewIncomingVoIPPushPayloadso that the main app can handle it
PKPushRegistry.didReceiveIncomingPushWithandCXProvider.reportNewIncomingCallto show the system UI and handle actions on it.N.B. this flow works properly only when background processing capabilities are enabled