Queue notifications in an async stream instead of blocking forward progress. #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated by 🚫 Danger Swift against a204f6b |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2946 +/- ##
===========================================
+ Coverage 77.92% 77.97% +0.04%
===========================================
Files 691 691
Lines 54048 54045 -3
===========================================
+ Hits 42116 42140 +24
+ Misses 11932 11905 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2944 introduced a
DispatchSemaphorewithin aTask. Whilst that actual usage wouldn't cause an issue as the await time would be minimal in what is essentially a serial process, we should still follow the rules that all threads should be making forward progress. This PR replaces the semaphore with an async stream to handle notifications in a queue, 1-by-1.This provides a slightly nicer separation of concerns although now I'm looking at the structure of the NSE, it would be nice to go further and break out the
runmethod into its own type too that owns thecontentHandlerandmodifiedContentproperties.