-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a Client in AuthenticationService now that the Rust one has been removed. #2954
Conversation
Generated by 🚫 Danger Swift against e38d5d4 |
82649fd
to
d5d8f67
Compare
d5d8f67
to
e38d5d4
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2954 +/- ##
===========================================
- Coverage 78.45% 78.23% -0.22%
===========================================
Files 691 694 +3
Lines 54047 54172 +125
===========================================
- Hits 42405 42384 -21
- Misses 11642 11788 +146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Rust's AuthenticationService has been removed in matrix-org/matrix-rust-sdk#3594. This PR moves what was very simple logic that called into a
Client
directly into our app-side AuthenticationService.Can be reviewed commit-by-commit.