Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup how we setup the CallKit provider and have it be used for outgoing calls as well #2967

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Cleanup how we setup the CallKit provider and have it be used for outgoing calls as well #2967

merged 3 commits into from
Jun 27, 2024

Conversation

stefanceriu
Copy link
Member

…going calls as well

@stefanceriu stefanceriu requested a review from a team as a code owner June 25, 2024 09:31
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team June 25, 2024 09:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against c2461f4

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.26316% with 108 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (fa22b98) to head (c2461f4).
Report is 3 commits behind head on develop.

Files Patch % Lines
...rces/Services/ElementCall/ElementCallService.swift 0.00% 86 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 26.31% 14 Missing ⚠️
...urces/Screens/CallScreen/CallScreenViewModel.swift 0.00% 4 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 3 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2967      +/-   ##
===========================================
- Coverage    78.02%   77.90%   -0.12%     
===========================================
  Files          693      693              
  Lines        54172    54281     +109     
===========================================
+ Hits         42269    42290      +21     
- Misses       11903    11991      +88
Flag Coverage Δ
unittests 68.77% <5.26%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu
Cleanup how we setup the CallKit provider and have it be used for out…
57761ba 
…going calls as well

- tear down ElementCall screens when ending the call from the CXCallController
- make the call UI available in the task manager and lock screen
@stefanceriu stefanceriu force-pushed the stefan/elementCallServiceCleanup branch from a498328 to 57761ba Compare June 25, 2024 16:05
@stefanceriu stefanceriu requested review from pixlwave and Velin92 June 25, 2024 16:06
Velin92
Velin92 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few comments

@stefanceriu stefanceriu force-pushed the stefan/elementCallServiceCleanup branch from 0a701a7 to 85ea31a Compare June 26, 2024 06:51
@stefanceriu stefanceriu mentioned this pull request Jun 26, 2024
Closed
pixlwave
pixlwave approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👌

ElementX/Sources/Screens/CallScreen/CallScreenViewModel.swift Show resolved Hide resolved
ElementX/Sources/Services/ElementCall/ElementCallService.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/ElementCall/ElementCallService.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/ElementCall/ElementCallService.swift Show resolved Hide resolved
@stefanceriu stefanceriu force-pushed the stefan/elementCallServiceCleanup branch from c974e1e to c2461f4 Compare June 26, 2024 12:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu enabled auto-merge (squash) June 26, 2024 12:34
@stefanceriu stefanceriu changed the title Cleanup how we setup the CallKit provider and have it be used for out… Cleanup how we setup the CallKit provider and have it be used for outgoing calls as well Jun 26, 2024
@stefanceriu stefanceriu added pr-feature for a new feature pr-bugfix for bug fix labels Jun 26, 2024
@stefanceriu stefanceriu disabled auto-merge June 27, 2024 11:07
@stefanceriu stefanceriu merged commit 41d40d8 into develop Jun 27, 2024
10 of 11 checks passed
@stefanceriu stefanceriu deleted the stefan/elementCallServiceCleanup branch June 27, 2024 11:07
@pixlwave pixlwave removed the pr-feature for a new feature label Jun 27, 2024
@pixlwave pixlwave added pr-change for updates to an existing feature and removed pr-bugfix for bug fix labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@Velin92 Velin92 Velin92 approved these changes

Assignees
No one assigned
Labels
pr-change for updates to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanceriu @pixlwave @Velin92