Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove layout styling abstraction #2982

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 27, 2024

No description provided.

@Velin92 Velin92 added the pr-misc for other changes label Jun 27, 2024
@Velin92 Velin92 requested a review from a team as a code owner June 27, 2024 15:26
@Velin92 Velin92 requested review from pixlwave and removed request for a team June 27, 2024 15:26
@Velin92 Velin92 changed the title Remove layout styling Remove layout styling abstraction Jun 27, 2024
Copy link

Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 36a883c

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (064b1bf) to head (36a883c).

Files Patch % Lines
...omScreen/View/Timeline/EmoteRoomTimelineView.swift 50.00% 1 Missing ⚠️
...mScreen/View/Timeline/NoticeRoomTimelineView.swift 50.00% 1 Missing ⚠️
...ngs/SettingsScreen/SettingsScreenCoordinator.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2982      +/-   ##
===========================================
+ Coverage    77.45%   77.46%   +0.01%     
===========================================
  Files          693      693              
  Lines        54101    54037      -64     
===========================================
- Hits         41902    41860      -42     
+ Misses       12199    12177      -22     
Flag Coverage Δ
unittests 68.48% <89.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Velin92 Velin92 merged commit b7345aa into develop Jun 27, 2024
11 checks passed
@Velin92 Velin92 deleted the mauroromito/remove_layout_styling branch June 27, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants